Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: custom splash text #153

Merged
merged 4 commits into from
Aug 18, 2024
Merged

feat: custom splash text #153

merged 4 commits into from
Aug 18, 2024

Conversation

1673beta
Copy link
Owner

What

スプラッシュ画面でカスタムテキストを表示できるように

Why

https://c.koliosky.com/notes/9x1qfimblc7u0469

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Update CHANGELOG_CHERRYPICK.md
  • (If possible) Add tests

@1673beta
Copy link
Owner Author

/preview

Copy link

github-actions bot commented Aug 18, 2024

이 PR에 의한 api.json 차이

차이점은 여기에서 볼 수 있음
--- base
+++ head
@@ -646,6 +646,12 @@
                         "string",
                         "null"
                       ]
+                    },
+                    "customSplashText": {
+                      "type": "array",
+                      "items": {
+                        "type": "string"
+                      }
                     }
                   },
                   "required": [
@@ -760,7 +766,8 @@
                     "doNotSendNotificationEmailsForAbuseReport",
                     "emailToReceiveAbuseReport",
                     "enableReceivePrerelease",
-                    "skipVersion"
+                    "skipVersion",
+                    "customSplashText"
                   ]
                 }
               }
@@ -15840,6 +15847,15 @@
                       "string",
                       "null"
                     ]
+                  },
+                  "customSplashText": {
+                    "type": [
+                      "array",
+                      "null"
+                    ],
+                    "items": {
+                      "type": "string"
+                    }
                   }
                 }
               }

Get diff files from Workflow Page

@1673beta
Copy link
Owner Author

/preview

3 similar comments
@1673beta
Copy link
Owner Author

/preview

@1673beta
Copy link
Owner Author

/preview

@1673beta
Copy link
Owner Author

/preview

@1673beta
Copy link
Owner Author

tgaがうまく動いてないの、要対応かも

@1673beta 1673beta merged commit e8e2864 into develop Aug 18, 2024
16 of 21 checks passed
@1673beta 1673beta deleted the splash-screen branch August 18, 2024 16:52
noridev added a commit to kokonect-link/cherrypick that referenced this pull request Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant