Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 予約投稿 #129

Draft
wants to merge 7 commits into
base: develop
Choose a base branch
from
Draft

feat: 予約投稿 #129

wants to merge 7 commits into from

Conversation

1673beta
Copy link
Owner

@1673beta 1673beta commented Aug 6, 2024

What

予約投稿の実装

Why

close #81

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Update CHANGELOG_CHERRYPICK.md
  • (If possible) Add tests

@1673beta 1673beta added this to the 0.5.0 milestone Aug 6, 2024
Copy link

github-actions bot commented Aug 6, 2024

이 PR에 의한 api.json 차이

차이점은 여기에서 볼 수 있음
--- base
+++ head
@@ -58509,6 +58509,12 @@
                         "minimum": 1
                       }
                     }
+                  },
+                  "scheduledAt": {
+                    "type": [
+                      "integer",
+                      "null"
+                    ]
                   }
                 },
                 "if": {
@@ -58707,6 +58713,15 @@
                       }
                     }
                   },
+                  "SCHEDULED_TIME_IS_PAST": {
+                    "value": {
+                      "error": {
+                        "message": "The scheduled time is past.",
+                        "code": "SCHEDULED_TIME_IS_PAST",
+                        "id": "d6ccda8e-5430-11ef-8876-0242ac120002"
+                      }
+                    }
+                  },
                   "INVALID_PARAM": {
                     "value": {
                       "error": {

Get diff files from Workflow Page

@1673beta
Copy link
Owner Author

1673beta commented Aug 6, 2024

あんまりテーブル増やしたくなさがあるのでbackend/src/models/Note.tsに生やす方向で…
DB側ではtemp table使えば良い

@1673beta
Copy link
Owner Author

1673beta commented Aug 6, 2024

そもそもtempテーブルの使い方間違ってるからtempいらん、そのままnoteテーブルにはやす

@1673beta
Copy link
Owner Author

1673beta commented Aug 7, 2024

ジョブキューいじりたくね~

@1673beta
Copy link
Owner Author

1673beta commented Aug 7, 2024

もしscheduledAtとdeleteAtが存在する場合の処理書く必要あるな、投票と似たような処理で

Copy link

github-actions bot commented Aug 8, 2024

Thank you for sending us a great Pull Request! 👍
Please regenerate cherrypick-js type definitions! 🙏

example:

pnpm run build-cherrypick-js-with-types

@1673beta 1673beta removed this from the 0.5.0 milestone Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

予約投稿
1 participant