BUGFIX: Update the duration extraction from the Server-Timing header #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Recently the Server-Timing header value changed to:
cfRequestDuration;dur=74.000120, cfL4;desc="?proto=TCP,{rest_of_description_here}"
Therefore the split(';') will result in the following string:
dur=74.000120, cfL4
When executing the next float(part.split('=')[1]) it will return
"74.000120, cfL4" which cannot be transformed to a float.
This commit will try to extract it that way (in case the headers will
change back), and if not - it will extract assuming the new format
|
Oh man what the hell is going on here, their server suddenly has two "server-timing" response headers with different capitalisation |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently the Server-Timing header value changed to:
cfRequestDuration;dur=74.000120, cfL4;desc="?proto=TCP,{rest_of_description_here}"Therefore the
split(';')will result in the following string:dur=74.000120, cfL4When executing the next
float(part.split('=')[1])it will return74.000120, cfL4which cannot be transformed to a float.This commit will try to extract it that way (in case the headers will change back), and if not - it will extract assuming the new format