A helper to synchronize HA SSH keys for OTP #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laneshields
reviewed
Oct 27, 2021
helper/sync-ha-ssh-keys/README.md
Outdated
| @@ -0,0 +1,50 @@ | |||
| # t128-sync-ha-ssh-keys.pyz | |||
| This application allows ensures ssh keys for HA Session Smart Routers (SSR) are synchronized during OTP installation. | |||
There was a problem hiding this comment.
You probably want to remove "allows"
laneshields
reviewed
Oct 27, 2021
helper/sync-ha-ssh-keys/README.md
Outdated
| This application allows ensures ssh keys for HA Session Smart Routers (SSR) are synchronized during OTP installation. | ||
|
|
||
| ## Setup | ||
| An OTP installation requires a so called quickstart file, which can be downloaded from the SSR conductor. |
laneshields
reviewed
Oct 27, 2021
helper/sync-ha-ssh-keys/README.md
Outdated
| An OTP installation requires a so called quickstart file, which can be downloaded from the SSR conductor. | ||
|
|
||
| During the first boot from internal disk the bootstrap process can incorporate a USB drive connected to the router. | ||
| This USB drive has be named `BOOTSTRAP` and the downloaded quickstart file has to be renamed to `bootstrap.quickstart`. |
There was a problem hiding this comment.
I'd probably say that the drive must have a label BOOTSTRAP (just to be clear what we mean by name) and I'd just say name the file bootstrap.quickstart (not rename)
laneshields
reviewed
Oct 27, 2021
helper/sync-ha-ssh-keys/README.md
Outdated
| ## Build .pyz Files | ||
| The .pyz files are [compressed python archives](https://docs.python.org/3/library/zipapp.html) (similar to .jar files in the Java universe) which allow to execute the main python script inside the archive, but at the same time split up modules into separate files/folders. | ||
|
|
||
| The source code at comes with a shell script `create_pyz.bash` that creates the archive from the sources files. |
There was a problem hiding this comment.
I think you mean "the source code comes with..."
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.