Use srcset and sizes on img element in picture #191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, in the case where the image has multiple formats and multiple sizes, elventy-img would generate output somewhat like ``` <picture> <source type="image/webp" srcset="/img/KkPMmHd3hP-200.webp 200w, /img/KkPMmHd3hP-400.webp 400w" sizes="100vw"> <source type="image/jpeg" srcset="/img/KkPMmHd3hP-200.jpeg 200w, /img/KkPMmHd3hP-400.jpeg 400w" sizes="100vw"> <img alt="" src="/img/KkPMmHd3hP-200.jpeg" width="400" height="266"> </picture> ``` This change makes eleventy-img instead produce output like ``` <picture> <source type="image/webp" srcset="/img/KkPMmHd3hP-200.webp 200w, /img/KkPMmHd3hP-400.webp 400w" sizes="100vw"> <img alt="" src="/img/KkPMmHd3hP-200.jpeg" srcset="/img/KkPMmHd3hP-200.jpeg 200w, /img/KkPMmHd3hP-400.jpeg 400w" sizes="100vw" width="400" height="266"> </picture> ``` This adds srcset and sizes to the img tag, and doesn't produce a source tag for the same format provided by the img tag. The initial motivation around this was to get RespImageLint to stop complaining by adding srcset and sizes to the img tag. I'm not an HTML expert, and I'm not sure this change is strictly correct.
adamwolf
force-pushed
the
multiple-size-lowsrc
branch
from
a337070 to
0a6d0f9
Compare
|
Shipping with v3.2.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks, zachleat, for all your hard work. I really appreciate it.
Previously, in the case where the image has multiple formats and multiple sizes, eleventy-img would generate output somewhat like
This change makes eleventy-img instead produce output like
This adds srcset and sizes to the img tag, and doesn't produce a source tag for the same format provided by the img tag.
The initial motivation around this was to get RespImageLint to stop complaining by adding srcset and sizes to the img tag. I'm not an HTML expert, and I'm not sure this change is strictly correct. It seems to me to matter for browsers that don't support picture or don't support any of the formats in source tags.