Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

eleventy:optional attribute on Transform method tied to failOnError global option #259

Closed
zachleat opened this issue Dec 12, 2024 · 1 comment
Closed

eleventy:optional attribute on Transform method tied to failOnError global option #259

zachleat opened this issue Dec 12, 2024 · 1 comment
Labels
enhancement New feature or request
Milestone
Eleventy Image v6...

Comments

@zachleat
Copy link
Member

zachleat commented Dec 12, 2024 •
edited
Loading

  • <img eleventy:optional>: removes src attribute when it has an error.
  • <img eleventy:optional="keep">: leave as-is, this would likely result in an error when a user visits your page (unless you are handling it independently).
  • <img eleventy:optional="placeholder">: replaces src with a transparent png data URI.

Related to #225 but with the transform method, make a specific image optional (failOnError: false)
@zachleat zachleat added the enhancement New feature or request label Dec 12, 2024
@zachleat zachleat added this to the Eleventy Image v6.0.0 milestone Dec 12, 2024
@zachleat zachleat mentioned this issue Dec 12, 2024
Closed
@zachleat
Copy link
Member Author

Shipping with v6.0.0-beta.1

zachleat added a commit that referenced this issue Dec 13, 2024
@zachleat
Adds keep and replace options to eleventy:optional attribute. #259
f387074
zachleat added a commit that referenced this issue Dec 13, 2024
@zachleat
Fix tests for #259
9f67cd9
zachleat added a commit that referenced this issue Dec 13, 2024
@zachleat
Change replace to placeholder for #259
2ca4a6e
zachleat added a commit that referenced this issue Dec 13, 2024
@zachleat
On #259 when an image errors and eleventy:optional=keep revert to the…
a7c949c 
… original source attribute. Fixes #257
@zachleat zachleat mentioned this issue Dec 13, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
Eleventy Image v6.0.0
Development

No branches or pull requests
1 participant
@zachleat