Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keep ICC profiles by default #244

Closed
pcarrier opened this issue Sep 10, 2024 · 3 comments
Closed

Keep ICC profiles by default #244

pcarrier opened this issue Sep 10, 2024 · 3 comments
Labels
breaking change This will have to be included with a major version as it breaks backwards compatibility. enhancement New feature or request
Milestone
Eleventy Image v6...

Comments

@pcarrier
Copy link

pcarrier commented Sep 10, 2024 •
edited
Loading

sharp exposes keepIccProfile, which is important to retain all the colors of Display-P3 and AdobeRGB images.

For example, check out the intensity of the green on the signage and table @ https://nothing.pcarrier.com/posts/riviere-des-parfums/ compared to the (linked) original images.
If your display supports significantly more than sRGB, the difference should be notable.
@zachleat zachleat added this to the Eleventy Image v6.0.0 milestone Dec 20, 2024
@zachleat zachleat added duplicate This issue or pull request already exists enhancement New feature or request labels Dec 20, 2024
@zachleat
Copy link
Member

Enabled by #52, shipping soon with v6.0.0-beta.1

If you think we should change the default in Eleventy Image, please let me know!

@ScreenDream
Copy link

+1 I would vote to keep ICC profiles as default.

@zachleat zachleat changed the title Control over ICC profiles Keep ICC profiles by default Jan 2, 2025
zachleat added a commit that referenced this issue Jan 2, 2025
@zachleat
Breaking: change default to keep icc profiles #244
263f5fa
@zachleat zachleat added breaking change This will have to be included with a major version as it breaks backwards compatibility. and removed duplicate This issue or pull request already exists labels Jan 2, 2025
@zachleat
Copy link
Member

zachleat commented Jan 2, 2025

.keepIccProfile() will be enabled by default in Eleventy Image v6.0.0-beta.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
breaking change This will have to be included with a major version as it breaks backwards compatibility. enhancement New feature or request
Projects
None yet
Milestone
Eleventy Image v6.0.0
Development

No branches or pull requests
3 participants
@pcarrier @zachleat @ScreenDream