Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade dependencies to get rid of deprecation warnings #46

Merged
merged 4 commits into from
Oct 21, 2024

Conversation

Zegnat
Copy link
Contributor

@Zegnat Zegnat commented Jul 22, 2024

Running npm install --omit "dev" before this PR:

npm WARN deprecated [email protected]: This module is not supported, and leaks memory. Do not use it. Check out lru-cache if you want a good and tested way to coalesce async requests by a key value, which is much more comprehensive and powerful.
npm WARN deprecated [email protected]: Rimraf versions prior to v4 are no longer supported
npm WARN deprecated [email protected]: Glob versions prior to v9 are no longer supported

added 22 packages, and audited 23 packages in 7s

And after:

added 10 packages, and audited 11 packages in 7s

Warnings were caused by dependencies from flat-cache. Previously eleventy-fetch was blocked from updating because of the supported Node.js version, but now that 18+ is required we align with flat-cache again.

Overall these upgrades half our number of dependencies and get rid of all the warnings! 🥳

Additional notes:

  1. p-queue has gone ESM-only. For now, eleventy-fetch has not made that step. This PR pins the p-queue dependency to the exact last non-ESM version.

  2. AVA is upgraded to the latest version of the test runner. This will result in an Unsupported engine warning on Node.js below version 18.18. However I was able to run the eleventy-fetch tests with AVA on Node.js v18.0.0 no problem, and I think it is worth the warning (for developers only) to be able to keep dependencies in check.

@zachleat zachleat added this to the Eleventy Fetch v5.0.0 milestone Oct 21, 2024
@zachleat zachleat merged commit 058bbff into 11ty:master Oct 21, 2024
@zachleat
Copy link
Member

Thank you! Shipping with Eleventy Fetch v5.0.0

@zachleat zachleat added the chore label Oct 22, 2024
@Zegnat Zegnat deleted the upgrade-dependencies branch October 23, 2024 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants