Merge pull request #34 from Zegnat/cache-request-verbs-separately

Cache request verbs separately

README.md

@@ -35,6 +35,7 @@ npm run test
 ```
 
 - We use the [ava JavaScript test runner](https://github.com/avajs/ava) ([Assertions documentation](https://github.com/avajs/ava/blob/master/docs/03-assertions.md))
+- Running tests requires Node 14.18+
 - ℹ️ To keep tests fast, thou shalt try to avoid writing files in tests.
 
 <!--

src/RemoteAssetCache.js

@@ -10,7 +10,17 @@ class RemoteAssetCache extends AssetCache {
 		if (options.removeUrlQueryParams) {
 			cleanUrl = RemoteAssetCache.cleanUrl(cleanUrl);
 		}
-		super(cleanUrl, cacheDirectory, options);
+		let cacheKey = [cleanUrl];
+		if(options.fetchOptions) {
+			if(options.fetchOptions.method && options.fetchOptions.method !== "GET") {
+				cacheKey.push(options.fetchOptions.method);
+			}
+			if(options.fetchOptions.body) {
+				cacheKey.push(options.fetchOptions.body);
+			}
+		}
+		cacheKey = cacheKey.length > 1 ? JSON.stringify(cacheKey) : cleanUrl;
+		super(cacheKey, cacheDirectory, options);
 
 		this.url = url;
 		this.options = options;

test/RemoteAssetCacheTest.js

@@ -69,6 +69,39 @@ test("Unique hashes for URLs", async (t) => {
 	t.not(cachePath1, cachePath2);
 });
 
+test("Same hashes for implicit and explicit HTTP GET", async t => {
+	let sameURL = 'https://example.com/';
+	let cachePath1 = new RemoteAssetCache(sameURL, ".cache", {
+		fetchOptions: { method: "GET" }
+	}).cachePath;
+	let cachePath2 = new RemoteAssetCache(sameURL, ".cache", {
+		fetchOptions: {  }
+	}).cachePath;
+	t.is(cachePath1, cachePath2);
+});
+
+test("Unique hashes for different HTTP methods", async t => {
+	let sameURL = 'https://example.com/';
+	let cachePath1 = new RemoteAssetCache(sameURL, ".cache", {
+		fetchOptions: { method: "POST" }
+	}).cachePath;
+	let cachePath2 = new RemoteAssetCache(sameURL, ".cache", {
+		fetchOptions: { method: "DELETE" }
+	}).cachePath;
+	t.not(cachePath1, cachePath2);
+});
+
+test("Unique hashes for different HTTP bodies", async t => {
+	let sameURL = 'https://example.com/';
+	let cachePath1 = new RemoteAssetCache(sameURL, ".cache", {
+		fetchOptions: { body: "123" }
+	}).cachePath;
+	let cachePath2 = new RemoteAssetCache(sameURL, ".cache", {
+		fetchOptions: { body: "456" }
+	}).cachePath;
+	t.not(cachePath1, cachePath2);
+});
+
 test("Fetching!", async (t) => {
 	let pngUrl = "https://www.zachleat.com/img/avatar-2017-big.png";
 	let ac = new RemoteAssetCache(pngUrl);