Refactor TableChart to set default value for cross_filtering_on_click…

… prop and ensure it is passed through transformProps
10webio · Jan 17, 2025 · 7677780 · 7677780
1 parent 6b50bff
commit 7677780
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 1 deletion.
diff --git a/superset-frontend/plugins/plugin-chart-table/src/TableChart.tsx b/superset-frontend/plugins/plugin-chart-table/src/TableChart.tsx
@@ -265,7 +265,7 @@ export default function TableChart<D extends DataRecord = DataRecord>(
     isUsingTimeComparison,
     basicColorFormatters,
     basicColorColumnFormatters,
-    cross_filtering_on_click,
+    cross_filtering_on_click = false,
   } = props;
   const comparisonColumns = [
     { key: 'all', label: t('Display all') },

diff --git a/superset-frontend/plugins/plugin-chart-table/src/transformProps.ts b/superset-frontend/plugins/plugin-chart-table/src/transformProps.ts
@@ -404,6 +404,7 @@ const transformProps = (
     comparison_color_enabled: comparisonColorEnabled = false,
     comparison_color_scheme: comparisonColorScheme = ColorSchemeEnum.Green,
     comparison_type,
+    cross_filtering_on_click,
   } = formData;
   const isUsingTimeComparison =
     !isEmpty(time_compare) &&
@@ -643,6 +644,7 @@ const transformProps = (
     basicColorFormatters,
     startDateOffset,
     basicColorColumnFormatters,
+    cross_filtering_on_click,
   };
 };
 

diff --git a/superset-frontend/plugins/plugin-chart-table/src/types.ts b/superset-frontend/plugins/plugin-chart-table/src/types.ts
@@ -146,6 +146,7 @@ export interface TableChartTransformedProps<D extends DataRecord = DataRecord> {
   basicColorFormatters?: { [Key: string]: BasicColorFormatterType }[];
   basicColorColumnFormatters?: { [Key: string]: BasicColorFormatterType }[];
   startDateOffset?: string;
+  cross_filtering_on_click?: boolean;
 }
 
 export enum ColorSchemeEnum {