Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed error Call to undefined method <test class>::getAnnotations() #164

Merged
merged 5 commits into from
Sep 22, 2022

Conversation

kudinovfedor
Copy link
Contributor

@kudinovfedor kudinovfedor commented Dec 2, 2021

@ericmann Fixes #158

@kudinovfedor kudinovfedor marked this pull request as draft December 2, 2021 16:00
@kudinovfedor kudinovfedor marked this pull request as ready for review December 2, 2021 16:00
@jeffpaul jeffpaul added this to the Future Release milestone Dec 2, 2021
@jeffpaul jeffpaul requested a review from ericmann December 2, 2021 16:21
@jeffpaul
Copy link
Member

jeffpaul commented Dec 2, 2021

Pinging @ericmann for review on this

@kudinovfedor
Copy link
Contributor Author

Hello, what about my fix?

@fiskhandlarn
Copy link

fiskhandlarn commented Jul 18, 2022

@ericmann @jeffpaul
i just tried this with my package blade. i bumped phpunit/phpunit from 9.4.4 to ^9.5 (which gave me 9.5.21), then i added https://github.com/kudinovfedor/wp_mock/tree/fix/annotations by adding this to my composer.json:

  "repositories": [
    {
        "type": "vcs",
        "url": "https://github.com/kudinovfedor/wp_mock.git"
    }
  ]

then i ran composer require --dev "10up/wp_mock":"dev-fix/annotations". my tests came out ok and green (with no warnings about missing getAnnotations()).

afaics this pr should be good to go!

faisal-alvi added a commit to 10up/simple-local-avatars that referenced this pull request Aug 10, 2022
@coveralls
Copy link

coveralls commented Sep 19, 2022

Coverage Status

Coverage decreased (-0.02%) to 10.296% when pulling 7d31b2f on kudinovfedor:fix/annotations into a59821c on 10up:trunk.

@unfulvio-godaddy unfulvio-godaddy merged commit 61e95de into 10up:trunk Sep 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WP_Mock breaks with PhpUnit >= 9.5.0
5 participants