Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introducing Package file #94

Merged
merged 4 commits into from
Jan 6, 2022
Merged

Introducing Package file #94

merged 4 commits into from
Jan 6, 2022

Conversation

faisal-alvi
Copy link
Member

Description of the Change

The package file is introduced.

Benefits

Helpful in cases where a new script is required like #85 (comment). Added uglifyjs script to overcome the mentioned issue.

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests passed.

@faisal-alvi faisal-alvi requested review from a team and cadic and removed request for a team January 4, 2022 10:18
@faisal-alvi faisal-alvi self-assigned this Jan 4, 2022
@faisal-alvi faisal-alvi added the type:enhancement New feature or request. label Jan 4, 2022
@faisal-alvi faisal-alvi mentioned this pull request Jan 4, 2022
6 tasks
@jeffpaul jeffpaul added this to the 2.3.0 milestone Jan 4, 2022
@jeffpaul jeffpaul self-requested a review January 4, 2022 17:10
Copy link
Member

@jeffpaul jeffpaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@faisal-alvi you'll want to add those files to https://github.com/10up/simple-local-avatars/blob/develop/.gitattributes so that they don't end up in the released version.

@claytoncollie
Copy link
Contributor

@faisal-alvi A minor suggestion, but renaming uglifyjs to build would be a better name to build the assets.

@faisal-alvi
Copy link
Member Author

@claytoncollie Thanks for the suggestion, I had preserved the “build” for the actual building of the “whole project” whereas the uglifyjs is minimizing only one JS file. But as we do not have any other files to be built (for now), we can utilize the word “build”.

@faisal-alvi faisal-alvi requested a review from jeffpaul January 5, 2022 10:29
@jeffpaul
Copy link
Member

jeffpaul commented Jan 5, 2022

Odd that the previous commit passed checks but the latest failed. Given that its WP Acceptance (and that we should be setting up Cypress e2e tests here anyway) I think I'm fine with this for now (ideally we get those e2e tests in place before the next release).

@jeffpaul jeffpaul merged commit 2f07c51 into develop Jan 6, 2022
@jeffpaul jeffpaul deleted the Enhancement/Package-file branch January 6, 2022 17:39
@ajmaurya99 ajmaurya99 mentioned this pull request Feb 1, 2022
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:enhancement New feature or request.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants