-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introducing Package file #94
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@faisal-alvi you'll want to add those files to https://github.com/10up/simple-local-avatars/blob/develop/.gitattributes so that they don't end up in the released version.
@faisal-alvi A minor suggestion, but renaming |
@claytoncollie Thanks for the suggestion, I had preserved the “build” for the actual building of the “whole project” whereas the |
Odd that the previous commit passed checks but the latest failed. Given that its WP Acceptance (and that we should be setting up Cypress e2e tests here anyway) I think I'm fine with this for now (ideally we get those e2e tests in place before the next release). |
Description of the Change
The package file is introduced.
Benefits
Helpful in cases where a new
script
is required like #85 (comment). Addeduglifyjs
script to overcome the mentioned issue.Checklist: