Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add settings link to plugin action links. #92

Merged
merged 3 commits into from
Feb 22, 2022

Conversation

rahulsprajapati
Copy link
Contributor

@rahulsprajapati rahulsprajapati commented Dec 8, 2021

Description of the Change

Add a settings link next to plugin deactivation action link to point it to plugin's custom settings page.

image

Alternate Designs

Benefits

Possible Drawbacks

Verification Process

TODO:

  • Add screenshot for settings page.

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests passed.

Applicable Issues

Closes: #87

Changelog Entry

  • Add plugin settings action link. [ Credits @ggedde / https://profiles.wordpress.org/ggedde/ for the inspiration on this. ]

Additional context

Ensure that any PR and associated release that adds this to SLA credits @ggedde / https://profiles.wordpress.org/ggedde/ for the inspiration on this.

@rahulsprajapati rahulsprajapati marked this pull request as draft December 8, 2021 18:27
@jeffpaul jeffpaul added this to the 87 milestone Dec 8, 2021
@jeffpaul jeffpaul requested review from a team and iamdharmesh and removed request for a team December 8, 2021 18:31
@rahulsprajapati rahulsprajapati force-pushed the feature/add-settings-link branch from c6e397e to 27e6087 Compare December 8, 2021 18:53
@jeffpaul jeffpaul modified the milestones: 87, Future Release Jan 4, 2022
@jeffpaul
Copy link
Member

I don't think its necessary to have a screenshot showing the two checkbox site settings, so moving this out of draft status and ready for review.

@jeffpaul jeffpaul marked this pull request as ready for review February 16, 2022 15:14
Copy link
Member

@iamdharmesh iamdharmesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rahulsprajapati Thanks for the great work here!
LGTM!! 👍

@jeffpaul jeffpaul modified the milestones: Future Release, 2.3.0 Feb 22, 2022
@jeffpaul jeffpaul merged commit 418d4b7 into develop Feb 22, 2022
@jeffpaul jeffpaul deleted the feature/add-settings-link branch February 22, 2022 03:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Settings link after activation and associated settings screenshot + copy
3 participants