Add option to clear cache of user meta to remove image sizes that do not exist #90
Conversation
There was a problem hiding this comment.
@thrijith In this PR, we're deleting cache for the current admin user, normal users can't delete the cache because they don't have access to the setting page. Besides, the main usage of this feature is deleting the cache after regenerating thumbnails, which only admins can perform.
I think the deleting cache function should delete the avatar cache for all users instead. We also need to care about the performance of large sites that have many users.
@dinhtungdu I've made some changes, please check again when you get a chance, thanks! |
There was a problem hiding this comment.
@thrijith This is likely to have timeout issues IMO. For large sites with a lot of users, it would take time to get all users, check and update the meta for each user. We're doing everything in a page load, which is not reliable to me. I think Ajax can be the solution to this issue.
@dinhtungdu please check again when you get a chance, thanks! |
assets/js/admin.js
Outdated
| } | ||
| }, | ||
| error : function () { | ||
| alert(slaAdmin.error); |
There was a problem hiding this comment.
Instead of alert, can we print the error message below the clear cache button? By doing so we can display more detailed errors. We can even add the status there too, for example:
There was a problem hiding this comment.
Added the message span below the button, demo https://cln.sh/u5NhwT
| } | ||
| } | ||
|
|
||
| if ( ! empty( $rows ) ) { |
There was a problem hiding this comment.
Instead of creating $row to hold only user IDs, I think we can use the $users variable above to check for the end of the progress.
There was a problem hiding this comment.
@dinhtungdu I've updated this, please check again when you get a chance, thanks!
Co-authored-by: Tung Du <[email protected]>
Description of the Change
Clear Cachebutton inSettings->Discussion, which updates the user meta to remove images that don't exist.Alternate Designs
N/A
Benefits
Possible Drawbacks
N/A
Verification Process
Regenerate ThumbnailspluginTools->Regenerate Thumbnails, selectDelete thumbnail files for old unregistered sizes in order to free up server space. This may result in broken images in your posts and pages.checkbox and regenerate the thumbnails.Settings->Discussionand use theClear Cacheto fix the issue.Checklist:
Applicable Issues
Fixs #31
Changelog Entry
Clear Cachebutton to fix broken avatar images after thumbnail regeneration.