Avatar rating text is not translated properly if a user has a custom language Set #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vikrampm1
requested review from
a team and
faisal-alvi
and removed request for
a team
faisal-alvi
requested changes
Nov 18, 2021
ActuallyConnor
force-pushed
the
fix/rating-custom-language-text-translation
branch
from
0d1d20b to
c013a00
Compare
|
@faisal-alvi I implemented a new solution and left some comments for clarity. Let me know if you have any questions or concerns. |
faisal-alvi
requested changes
Nov 19, 2021
|
@ActuallyConnor Thank you for the improved solution. I've left some suggestions, please check. |
Overwriting existing avatar_ratings so this can be called just before the rating strings would be used so that translations will work correctly. Default text-domain because the strings have already been translated Using esc_html over $ratings would be an extra improvement
|
@faisal-alvi I've made some changes based on your recommendations, let me know what you think |
faisal-alvi
reviewed
Nov 22, 2021
faisal-alvi
reviewed
Nov 22, 2021
faisal-alvi
requested changes
Nov 22, 2021
There was a problem hiding this comment.
@ActuallyConnor the solution looks good, thank you. There are a couple of errors from PHPCS, please fix them. Then we will be good to go.
|
@faisal-alvi those PHPCS errors should be fixed now 😄 |
faisal-alvi
approved these changes
Nov 23, 2021
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
Adding string translation method around each
$avatar_ratingwhen it is output in theedit_user_profile()method.Verification Process
Checklist:
Applicable Issues
#88