Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add: avatar preview for subscriber #74

Merged
merged 2 commits into from
Jun 14, 2021

Conversation

dinhtungdu
Copy link
Contributor

Fixes #73

@jeffpaul jeffpaul added this to the 2.3.0 milestone Apr 13, 2021
@jeffpaul jeffpaul requested a review from dkotter April 13, 2021 13:59
@jeffpaul jeffpaul added the type:enhancement New feature or request. label Apr 13, 2021
@dkotter
Copy link
Collaborator

dkotter commented Jun 10, 2021

@dinhtungdu Tested this out and works great. I am seeing a mix of tabs and spaces in the javascript, causing some spacing issues. Once that's all standardized to tabs, this is good to go.

Copy link
Collaborator

@dkotter dkotter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some spacing issues here that need cleaned up. Seems a mix of tabs and spaces and should standardize to just tabs.

@dinhtungdu
Copy link
Contributor Author

@dkotter Thanks for the head-up! I corrected the indentation.

@dinhtungdu dinhtungdu requested a review from dkotter June 11, 2021 00:24
@dinhtungdu dinhtungdu merged commit fb7c908 into develop Jun 14, 2021
@dinhtungdu dinhtungdu deleted the fix/subscriber-avartar-preview branch June 14, 2021 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:enhancement New feature or request.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Preview is not getting generated for Subscriber user
3 participants