Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update wp tested-up-to 5.3 in readme.txt #38

Merged
merged 1 commit into from
Jan 7, 2020

Conversation

jeffpaul
Copy link
Member

@jeffpaul jeffpaul commented Jan 7, 2020

Description of the Change

Mimics #36 to the master branch to trigger the GitHub Action.

Alternate Designs

none

Benefits

Ensures the plugin bump deploys to .ORG.

Possible Drawbacks

none identified.

Verification Process

Manually verified via the GitHub web UI.

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests passed.

Applicable Issues

Relates to #35

@jeffpaul jeffpaul added this to the 2.2 milestone Jan 7, 2020
@jeffpaul jeffpaul self-assigned this Jan 7, 2020
@jeffpaul jeffpaul merged commit 8d6c65e into master Jan 7, 2020
@jeffpaul jeffpaul mentioned this pull request Jan 7, 2020
5 tasks
@jeffpaul
Copy link
Member Author

Huh, don't know why the GitHub Action didn't pick this up and update .ORG. Will have to investigate what's going on there.

@dinhtungdu
Copy link
Contributor

@jeffpaul, you need to merge new commits from develop to master to get the action triggered for the current configuration.

name: Plugin asset/readme update
on:
  push:
    branches:
    - master

@jeffpaul
Copy link
Member Author

Nice catch @dinhtungdu, looks like there's a small update in the main plugin file so we'll get those changes into master in our next release version (likely one targeting the work from #40).

@jeffpaul jeffpaul deleted the update/wp-tested-version branch June 30, 2020 03:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants