Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
This PR updates all of our outdated direct node dependencies.
It also resolves two security issues with dependencies other dependencies are including. Dependabot normally fixes those but it seems to be having issues with these two (for those with access, can see this under the
Security > Dependabot
setting).Here's what I did:
package.json
file, bump those to the latest version, except formochawesome-json-to-md
as this is known to break our E2E workflowpackage-lock.json
filenpm install
to bring in all the latest versions of packagesnpm audit
to see if any security issues remain@sentry/node
and one withpuppeteer-core
. These are dependencies used by thelighthouse
dependency, which is relied on by@wordpress/scripts
. We're already using the latest version of@wordpress/scripts
so updating that won't fix things. Instead, I directly updated those dependencies to their latest in thepackage-lock.json
file. This fixes the security issues for now though those updates will be wiped out the next time we update@wordpress/scripts
How to test the Change
Verify all tests pass on this PR
Changelog Entry
Credits
Props @dkotter
Checklist: