Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avatar removal button text update #208

Merged
merged 1 commit into from
Mar 24, 2023
Merged

Avatar removal button text update #208

merged 1 commit into from
Mar 24, 2023

Conversation

jayedul
Copy link
Contributor

@jayedul jayedul commented Mar 23, 2023

Description of the Change

Avatar removal text changed to Remove local avatar from Delete local avatar. This PR is created based on this comment on PR #180

Closes #41

How to test the Change

  • Go to profile edit page
  • Set local avatar and save
  • Now you should see removal button text is Remove local avatar

Changelog Entry

Changed - Avatar removal button text

Credits

Props @jayedul, @dkotter, @faisal-alvi

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

@jayedul jayedul self-assigned this Mar 23, 2023
@jayedul jayedul marked this pull request as ready for review March 23, 2023 09:59
@jayedul jayedul requested a review from faisal-alvi as a code owner March 23, 2023 09:59
@jeffpaul jeffpaul added this to the 2.7.5 milestone Mar 23, 2023
@faisal-alvi faisal-alvi merged commit b6634c1 into develop Mar 24, 2023
@faisal-alvi faisal-alvi deleted the fix/41-text-update branch March 24, 2023 09:08
@faisal-alvi faisal-alvi mentioned this pull request Mar 24, 2023
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@faisal-alvi faisal-alvi faisal-alvi approved these changes

Assignees

@jayedul jayedul

Labels
None yet
Projects
None yet
Milestone
2.7.5
Development

Successfully merging this pull request may close these issues.

Option to prevent media deletion
3 participants
@jayedul @faisal-alvi @jeffpaul