-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support WP_User objects #193
Conversation
9737ad8
to
ae87308
Compare
I'm not so familiar with WP_Mock, but I've made some changes so that I can mock a WP_User object. Please advise if there is a better way to do this. Thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor spacing fixes
@mattheu Awesome! thank you for working on this. ✅ Checked the following code and the avatar works well in the PR branch. Can you please just make those small spacing fixes and we will be good to go!
in in this PR: |
Co-authored-by: Faisal Alvi <[email protected]>
Thanks. Suggestions applied. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mattheu thank you for your efforts! 🚀
Description of the Change
It is expected that I can pass
WP_User
object toget_avatar
, as is documented. But this does not work becauseget_user_id
inSimple_Local_Avatars
does not handle this case.Closes #192
How to test the Change
Changelog Entry
Credits
Props @mattheu
Checklist: