Fix/144 Update the release process #145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffpaul
reviewed
Aug 15, 2022
jeffpaul
reviewed
Aug 15, 2022
There was a problem hiding this comment.
Curious why not just update
simple-local-avatars/.github/workflows/push-deploy.yml
Lines 2 to 5 in 703ab09
|
@jeffpaul we have already used the Github publish as seen in the ElasitcPress. simple-local-avatars/.github/workflows/push-deploy.yml Lines 2 to 4 in a179844 Please let me know if this is not what you are trying to point out. |
|
@faisal-alvi yes, I think mimicking EP and releasing when we publish on GH (vs. just on tagging) makes most sense to me; please update there and then I think this is good to merge. |
jeffpaul
approved these changes
Aug 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
This PR changes the release process so we can distribute the plugin via composer without needing WPackagist.
Closes #144
How to test the Change
Test it in the next release (2.6.0).
Changelog Entry
Changed: The plugin is now available via Composer without any additional steps required.
Credits
Props @faisal-alvi @kovshenin @jeffpaul
Checklist: