Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow WP Trunk E2E tests to fail. #959

Merged
merged 1 commit into from
Oct 19, 2022
Merged

Conversation

peterwilsoncc
Copy link
Collaborator

@peterwilsoncc peterwilsoncc commented Oct 19, 2022

Description of the Change

Due to an upstream bug in wordpress/env the E2E tests for WordPress trunk are failing. See WordPress/gutenberg#44887

As a temporary measure, these tests should be allowed to fail without blocking merge/ending the other E2E test runs early.

Closes #958

How to test the Change

Changelog Entry

Credits

Props @peterwilsoncc

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

@peterwilsoncc peterwilsoncc requested review from a team and Sidsector9 and removed request for a team October 19, 2022 02:21
@jeffpaul jeffpaul added this to the 2.0.0 milestone Oct 19, 2022
@jeffpaul
Copy link
Member

This approach works for me, we could also pause the running of the action entirely and avoid a code change in the future.

@jeffpaul jeffpaul merged commit 5c4e4e2 into develop Oct 19, 2022
@jeffpaul jeffpaul deleted the fix/958-e2e-trunk-failures branch October 19, 2022 02:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Temporarily allow E2E trunk tests to fail.
2 participants