Ensure we are on a multisite before using switch_to_blog
#780
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
As detailed in #773, if you use Distributor on a multisite and then convert some of those sites into single install sites, you can run into PHP fatal errors. The issue here is around our usage of
switch_to_blog
. We had checks in place to ensure we only used that if the proper Distributor meta was in place but in the above scenario, you can have that meta but actually not be on a multisite.This PR fixes that by adding
is_multisite()
checks to any function that usesswitch_to_blog
after checking for the existence of Distributor meta. This should prevent fatal errors from occurring in the above detailed scenario.Alternate Designs
None
Benefits
No PHP fatal errors will happen when using Distributor on sites that used to be part of a multisite
Possible Drawbacks
None
Verification Process
Checklist:
Applicable Issues
#773
Changelog Entry