Fix an an undefined variable issue #578
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
In #574, we removed a try/catch block in order to fix an issue where distribution didn't fully work and the post ID value is 0, instead of undefined. But within that try/catch block, we were setting a
$remote_id
variable that is then used twice after that.Because that code was removed, that variable then becomes undefined when it is referenced later, causing issues. Items will still distribute correctly but the connection will not be fully set up, so updates will not be pushed through.
This PR fixes this issue.
Alternate Designs
None
Benefits
Fixes undefined variable PHP errors and ensures connections are set up properly.
Possible Drawbacks
None
Verification Process
Checklist: