Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redirect to pulled content tab after content is pulled via the settings #575

Conversation

joshuaabenazer
Copy link
Contributor

Takes care of #504

Description of the Change

Redirect to the pulled content tab after content is pulled via the Pull Content Dashboard page

Benefits

The user will be taken to the Pulled Content page where in they will be able to view or edit the pulled content right after pulling it.

Possible Drawbacks

If the user wants to pull more than a single post but does not use the bulk pull feature, then they may get annoyed that they would need to head back to the "New" tab. Although for multiple pulls, the bulk pull feature should be used instead.

Verification Process

  1. Head over to Dashboard -> Distributor -> Pull Content
  2. Identify any post to be pulled and hit the "Pull" action or bulk "Pull" more than a single post
  3. Verify that you are now on the "Pull" tab which should have a list of the most recently pulled items

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests passed.

Applicable Issues

#504

Changelog Entry

  • Changed - Once content is pulled successfully via the "Pull Content" settings page, it redirects over to the "Pull" tab of the page instead of remaining in the default "New" tab

@jeffpaul jeffpaul added the type:enhancement New feature or request. label Apr 1, 2020
@jeffpaul jeffpaul added this to the 1.6.0 milestone Apr 1, 2020
@jeffpaul jeffpaul requested a review from dinhtungdu April 1, 2020 20:29
dinhtungdu
dinhtungdu previously approved these changes Apr 1, 2020
Copy link
Contributor

@dinhtungdu dinhtungdu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dkotter
Copy link
Collaborator

dkotter commented Apr 10, 2020

@joshuaabenazer Thanks for this PR! This looks good to me but what are your thoughts on also doing this for items that are marked as skipped? Should those redirect to the Skipped tab instead of staying on the current tab? I think it makes sense to have both Pulled and Skipped items function similarly but open to your thoughts on that.

@jeffpaul
Copy link
Member

jeffpaul commented May 6, 2020

@joshuaabenazer any thoughts on @dkotter's feedback and potential addition for this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:enhancement New feature or request.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants