New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix password field label for attribute #559

Merged

dkotter merged 1 commit into 10up:develop from samikeijonen:tweak/password-field-label

Apr 10, 2020

Contributor

samikeijonen commented Mar 17, 2020

Fixes #551.

Description of the Change

Change Password field for attribute to dt_password to match password field ID..

Benefits

Users can click password label to focus correct password field.
Screen reader users get correct info about the field.

Possible Drawbacks

None.

Verification Process

Edit connection.
Click password field.
Check that correct password field is focused.

Checklist:

I have read the CONTRIBUTING document.
My code follows the code style of this project.
My change requires a change to the documentation.
I have updated the documentation accordingly.
I have added tests to cover my change.
All new and existing tests passed.

Applicable Issues


          Fix password field label for attribute.

eac4fc0

jeffpaul assigned samikeijonen

jeffpaul added this to the 2.0.0 milestone

jeffpaul requested a review from dinhtungdu

March 18, 2020 01:58

jeffpaul added the type:bug label

dinhtungdu approved these changes

View reviewed changes

dkotter merged commit 01749e8 into 10up:develop

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels