-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generate Hook Docs with a GitHub Action #448
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e292711
to
4575f44
Compare
e0c5741
to
440f21b
Compare
Thoughts on adding a link to the resulting GitHub Page to distributorplugin.com? |
yes, we can do that in a follow up PR once this is merged and we are happy with how the GH pages look. |
ryanwelcher
approved these changes
Sep 16, 2019
6 tasks
5 tasks
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
Addresses #387.
@hook
notationwp-hookdoc
requires across the plugin for all instances ofapply_filter
anddo_action
. (side note: that was tedious, open an upstream issue to remove that requirement).@todo
notes, cleaned up a few arrays definitions that weren't getting parsed correctly.npm run build:docs
yaml
file that builds the docs for every commit to develop.Alternate Designs
Considered phpdoc-parser https://github.com/WordPress/phpdoc-parser which is used in WordPress core. This project seems more suited for GitHub Actions and our needs.
Benefits
Builds hook docs automatically with an action on each deploy.
Verification Process
npm install && npm run build:docs
.hook_docs/index.html
in a browser.Checklist:
Applicable Issues