Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add check for internal connection #1225

Merged
merged 1 commit into from
Jun 11, 2024
Merged

Add check for internal connection #1225

merged 1 commit into from
Jun 11, 2024

Conversation

kirtangajjar
Copy link
Member

@kirtangajjar kirtangajjar commented Jun 8, 2024 •
edited
Loading

Description of the Change

Adds a check to see if a connection is internal and if it's not, exits early.

Closes #1157

How to test the Change

  1. Open a URL with invalid connection id like: admin.php?page=pull&connection_type=external&connection_id=1.
  2. Check debug log and ensure that the no warning is shown.
  3. Open a URL with external connection and open it's screen as in step 1.
  4. Check debug log and ensure that the no warning is shown.
  5. Open a URL with network connection and open it's screen as in step 1
  6. Check debug log and ensure that the no warning is shown.

Changelog Entry

Fixed - Warning on invalid connection id

Credits

Props @kirtangajjar

Checklist:

  • I agree to follow this project's Code of Conduct.
  • All new and existing tests pass.

@kirtangajjar kirtangajjar requested a review from a team as a code owner June 8, 2024 23:00
@kirtangajjar kirtangajjar requested review from Sidsector9 and removed request for a team June 8, 2024 23:00
@github-actions github-actions bot added this to the 2.1.0 milestone Jun 8, 2024
@github-actions github-actions bot added the needs:feedback This requires reporter feedback to better understand the request. label Jun 8, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 8, 2024

@kirtangajjar thanks for the PR! Could you please fill out the PR template with description, changelog, and credits information so that we can properly review and merge this?

@github-actions github-actions bot added needs:code-review This requires code review. and removed needs:feedback This requires reporter feedback to better understand the request. labels Jun 8, 2024
@jeffpaul jeffpaul requested a review from peterwilsoncc June 9, 2024 01:32
peterwilsoncc
peterwilsoncc approved these changes Jun 11, 2024
View reviewed changes
Copy link
Collaborator

@peterwilsoncc peterwilsoncc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change looks good and tests well. Thanks Kirtan.

The failing E2E tests look to be due to markup changes in the editor rather than related to this pull request.

@peterwilsoncc peterwilsoncc merged commit 75c0bf3 into develop Jun 11, 2024
17 of 21 checks passed
@peterwilsoncc peterwilsoncc deleted the fix/internalcheck branch June 11, 2024 04:45
@dkotter dkotter modified the milestones: 2.1.0, 2.0.5 Aug 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peterwilsoncc peterwilsoncc peterwilsoncc approved these changes

@Sidsector9 Sidsector9 Awaiting requested review from Sidsector9 Sidsector9 is a code owner automatically assigned from 10up/open-source-practice

Assignees

@kirtangajjar kirtangajjar

Labels
needs:code-review This requires code review.
Projects
None yet
Milestone
2.0.5
Development

Successfully merging this pull request may close these issues.

PHP warning thrown visiting non-existent connection pull screen.
3 participants
@kirtangajjar @peterwilsoncc @dkotter