Merge pull request #1254 from 10up/fix/incorrect-featured-image

Fix incorrect featured image
10up · Aug 15, 2024 · 1f82529 · 1f82529
2 parents 37e11cb + ccaedc8
commit 1f82529
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/includes/classes/DistributorPost.php b/includes/classes/DistributorPost.php
@@ -633,7 +633,7 @@ protected function get_media() {
 		$media_array       = array();
 
 		foreach ( $raw_media as $media_post ) {
-			$media_item = Utils\format_media_post( $media_post );
+			$media_item = Utils\format_media_post( $media_post, $post_id );
 
 			if ( $media_item['featured'] ) {
 				$found_featured = true;

diff --git a/includes/utils.php b/includes/utils.php
@@ -802,18 +802,19 @@ function set_media( $post_id, $media, $args = [] ) {
  * This is a helper function for transporting/formatting data about a media post
  *
  * @param  \WP_Post $media_post Media post.
+ * @param  int      $post_id    Post ID.
  * @since  1.0
  * @return array
  */
-function format_media_post( $media_post ) {
+function format_media_post( $media_post, $post_id = 0 ) {
 	$media_item = array(
 		'id'    => $media_post->ID,
 		'title' => $media_post->post_title,
 	);
 
 	$media_item['featured'] = false;
 
-	if ( (int) get_post_thumbnail_id( $media_post->post_parent ) === $media_post->ID ) {
+	if ( $post_id && (int) get_post_thumbnail_id( $post_id ) === $media_post->ID ) {
 		$media_item['featured'] = true;
 	}