Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: JS error on copy clipboard #72

Merged
merged 2 commits into from
Mar 22, 2023
Merged

Fix: JS error on copy clipboard #72

merged 2 commits into from
Mar 22, 2023

Conversation

burhandodhy
Copy link
Contributor

@burhandodhy burhandodhy commented Mar 22, 2023 •
edited
Loading

Description of the Change

This PR fixes the issue where browser throws the JS error when site load on http

Closes #

How to test the Change

Changelog Entry

Fixed - JS error on copy action

Credits

Props @burhandodhy

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

@burhandodhy burhandodhy requested a review from felipeelia March 22, 2023 16:06
@burhandodhy burhandodhy added this to the 3.0.0 milestone Mar 22, 2023
@felipeelia felipeelia merged commit 7df2a0c into develop Mar 22, 2023
@burhandodhy burhandodhy deleted the fix-error-on-copy-clipboard-new branch March 22, 2023 16:58
felipeelia added a commit that referenced this pull request Mar 23, 2023
@felipeelia
Add #72 and #73
1ea9393
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felipeelia felipeelia Awaiting requested review from felipeelia

Assignees

@felipeelia felipeelia

Labels
None yet
Projects
None yet
Milestone
3.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@burhandodhy @felipeelia