Single button to copy all the info #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felipeelia
requested changes
Jan 31, 2023
There was a problem hiding this comment.
@MARQAS In addition to the git conflict we need to solve, we will need to make some changes on this one:
- We do not want to replace the "Copy cURL Request". That is useful when someone wants to replay a specific query.
- The button that copies everything can't be named "Copy cURL Requests" because it is copying much more than the cURL commands to replay the request. Something like "Copy Requests Info" would work better.
- We can come up with better formatting for the copied report. Following the format we have in the Status Report would make it easier to read.
In addition to that, it would be great if the user could also download the debug info as a txt file. I've created an issue in the ElasticPress repo talking about that.
burhandodhy
reviewed
Mar 22, 2023
| const request = copyBtn.getAttribute('data-request'); | ||
|
|
||
| copyBtn.addEventListener('click', function () { | ||
| navigator.clipboard.writeText(request).then(function () { |
There was a problem hiding this comment.
Getting this error Uncaught TypeError: Cannot read properties of undefined (reading 'writeText')
There was a problem hiding this comment.
@burhandodhy I wasn't able to reproduce this one. In which browser are you seeing this?
Co-authored-by: Burhan Nasir <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
This PR will replace the copy cURL buttons into a single copy button that will be used to copy the whole data instead of single cURL request. The position is also changed from bottom of the cURL request to top of all the cURL calls for better visibility and usage
Closes #59
How to test the Change
Changelog Entry
Credits
Props @MARQAS
Checklist: