Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release/1.2.0 #111

Merged
merged 11 commits into from
Jun 27, 2023
Merged

Release/1.2.0 #111

merged 11 commits into from
Jun 27, 2023

Conversation

jeffpaul
Copy link
Member

@jeffpaul jeffpaul commented Jun 8, 2023

Description of the Change

Release and version bump to 1.2.0.

Closes #110.

How to test the Change

Verify manually via VS Code or the GitHub UI.

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

@jeffpaul jeffpaul added this to the 1.2.0 milestone Jun 8, 2023
@jeffpaul jeffpaul requested a review from Sidsector9 June 8, 2023 20:40
@jeffpaul jeffpaul self-assigned this Jun 8, 2023
@jeffpaul
Copy link
Member Author

jeffpaul commented Jun 8, 2023

Note that there's a discrepancy between #66 && #104 that we need to resolve before continuing with this release.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Sidsector9 what was the PR/change that necessitated the WP/PHP minimum bumps here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jeffpaul jeffpaul marked this pull request as ready for review June 22, 2023 13:55
@jeffpaul jeffpaul requested review from a team and dsawardekar as code owners June 22, 2023 13:55
Sidsector9
Sidsector9 previously approved these changes Jun 22, 2023
@jeffpaul
Copy link
Member Author

Updated release date, so otherwise proceeding with the earlier release approval

@jeffpaul
Copy link
Member Author

Oh for the love of all things automated and holy, now a failing E2E test on WP trunk. Looking at the string of commits, there's nothing from when that test was passing previously until now that should cause that failure here within the plugin repo. My gut is that something wonky is going on in WordPress 6.3 (in fact there's a bit of a hiccup in the Beta 1 release) so I'm choosing to chalk it up to oddities there that we'll catch & update when it gets to testing for WP 6.3 compatibility / "tested up to".

@jeffpaul jeffpaul merged commit 918af94 into develop Jun 27, 2023
@jeffpaul jeffpaul deleted the release/1.2.0 branch June 27, 2023 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Release version 1.2.0
2 participants