Add shellcheck for automated testing #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 3, 2020
Closed
szepeviktor
approved these changes
Apr 3, 2020
|
Thank you. |
helen
added a commit
that referenced
this pull request
May 26, 2020
Add zip generation steps to output zip_path, Closes #34
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
Adds Shellcheck via an existing GH Action for automated tests on PRs and pushes to develop.
Alternate Designs
Installing shellcheck and running the command directly in the workflow.
Benefits
Better code, hopefully.
Possible Drawbacks
None that I can think of.
Verification Process
I read through the entrypoint file in the Action referenced but otherwise just going to let it test by opening this PR and seeing what happens.
Checklist:
Applicable Issues
Fixes #29
Changelog Entry
n/a