Fix: Term sync issue during the pagination #4102
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felipeelia
reviewed
Mar 6, 2025
| * @since 3.4 | ||
| * @return {array} New arguments | ||
| */ | ||
| $total_objects = wp_count_terms( apply_filters( 'ep_term_all_query_db_args', $all_query_args, $args ) ); |
There was a problem hiding this comment.
Shouldn't we add this filter somewhere else now?
There was a problem hiding this comment.
The filter is still used when advanced_pagination is not set
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
This PR fixes the issue where an incorrect number of terms were synced when pagination was used. The problem started occurring after merging this change #3654.
Closes #
How to test the Change
Run
wp elasticpress sync --setup --show-errors --yes --indexables=term --per-page=10command and confirm if all the terms are synced.Changelog Entry
Credits
Props @burhandodhy
Checklist: