This repository has been archived by the owner on May 26, 2024. It is now read-only.
Changed rmc_isGxGGA to be called gga_isGxGGA for consistency #46
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I've gone through all the code of this library and changed the rmc_isGxGGA functions to be called gga_isGxGGA. The RMC functions rmc_isGxRMC are untouched. I've just changed the prefix on the GGA functions to be gga rather than rmc, since they have nothing to do with RMC strings. For the sake of consistency and readability, I believe the GGA functions should be called gga. I suspect the fact that they start with rmc is a matter of old copy-pasted code sticking around and renaming them would aid the codebase in being more self consistent and comprehensible.
I realize this would make new versions fail to be backward compatible with old code which may use these rmc_isGxGGA functions. However, it seems unlikely that many users would be using these, since primarily the identification of commands is handled within the library itself, and given that I've already changed all the calls within the library to use the new "gga_" versions, this incompatibility should be minor.
Thank you for considering this pull request. If approved, I hope to also add other NMEA strings to this library, including GPGSV.