[TECH] Mettre à jour les tailles de différentes typographies (PIX-15000). #765
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jeyffrey
added
👀 Design Review Needed
👀 Tech Review Needed
cross-team
|
Une fois l'application déployée, elle sera accessible à cette adresse https://ui-pr765.review.pix.fr |
Jeyffrey
changed the title
xav-car
reviewed
Nov 19, 2024
| @@ -15,15 +15,19 @@ | |||
| --font-size-title: 2rem; | |||
|
|
|||
| font-size: var(--font-size-title); | |||
| line-height: 1.3; | |||
| line-height: 2.625rem; | |||
There was a problem hiding this comment.
question il me semblait qu'on avait eu des souci avec le line-height en rem plutôt quand % 🤔 . mais je ne m'en rappel plus bien
There was a problem hiding this comment.
Ah ouais ? Étonnant !
Je vais me renseigner
There was a problem hiding this comment.
Ok pour le design, a voir côté tech pour cette histoire de rem 😉
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎄 Problème
Les tailles de font ne sont pas les mêmes que celles mentionnées dans le fichier Figma.
De ce fait, tous les outils Pix affichent des textes beaucoup trop gros.
🎁 Proposition
Mettre à jour avec les bonnes tailles
🎅 Pour tester
Vérifier que les
font-sizeetline-heightcorrespondent bien au tableau présent sur Figma.