Ne pas afficher les commandes exécutés dans les scripts de publication pour ne pas afficher les tokens en prod #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VincentHardouin
approved these changes
Jul 19, 2021
aceol
approved these changes
Jul 20, 2021
| @@ -1,6 +1,6 @@ | |||
| #!/bin/bash | |||
|
|
|||
| set -euxo pipefail | |||
| set -euo pipefail | |||
There was a problem hiding this comment.
if [ "$DEBUG" == "true" ];
then
set -euxo pipefail;
else
set -euo pipefail;
fi
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦄 Problème
Voir #78. L'utilisation de sed n'étant pas idéale, chez repris la proposition de Jonathan.
🤖 Solution
Ne pas afficher les commandes bash dans la sortie du script
🌈 Remarques
J'ai tenté d'utiliser le stockage des credentials de git, mais je ne vois pas comment l'utiliser tout en évitant d'afficher le token dans la sortie.
💯 Pour tester
Faire une release et vérifier que les commandes bash ne sont plus affichées.