Pouvoir saisir des noms d'app raccourci sur la commande app-status #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
celineung
changed the title
laura-bergoens
approved these changes
Mar 30, 2021
bpetetot
reviewed
Mar 30, 2021
clemlatz
force-pushed
the
improve-app-status
branch
from
0bcef5a to
a3e5a08
Compare
clemlatz
force-pushed
the
improve-app-status
branch
from
a3e5a08 to
3068497
Compare
bpetetot
approved these changes
Mar 31, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦄 Problème
Il peut être lourd de devoir saisir le nom entier de l'application lors de l'appel à la commande Slack
/app-status🤖 Solution
Permettre à la commande Slack de comprendre les noms raccourcis des applications.
Dans ce cas, ce sera automatiquement l'application de prod qui sera visée.
Ex:
/app-status pix-app-production/app-status app: cette commande retournera le status de l'application pix-app-production🌈 Remarques
On a aussi porfité de cette PR pour corriger un problème sur la commande.
Sur la PR #65 qui permet de remonter sur Slack le status d'un application Scalingo, on remarque que le status de l'api est toujours DOWN parce que l'on ping
https://app.{environement}.pix.fret non pashttps://app.{environement}.pix.fr/api.Fix: lorsque l'application demandée est l'api, suffixer l'url de ping par
/api