[BUGFIX] Eviter les 500 dans le controller GitHub #494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Une fois l'application déployée, elle sera accessible à cette adresse https://bot-pr494.review.pix.fr |
VincentHardouin
changed the title
HEYGUL
approved these changes
Dec 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎄 Problème
Actuellement, nous avons des 500 dans le controller github dans le if correspondant aux events
check_suite, car Hapi.js souhaite que le controller retourne quelque chose.🎁 Proposition
Ajouter les retours manquants
🧦 Remarques
D'autres conditions fonctionnent mais utilisent le return
Ignoring action, ce qui n'est pas génial non plus;🎅 Pour tester