Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TECH] Tracer avec le logger dédié partout (PIX-8176) #252

Merged
merged 1 commit into from
May 30, 2023

Conversation

mickaelalibert
Copy link
Contributor

@mickaelalibert mickaelalibert commented May 25, 2023

🦄 Problème

Certains logs sont effectués avec la console alors qu'un logger est disponible.
Cela ne facilite pas la maintenance.

🤖 Proposition

Utilisr le logger.

💯 Pour tester

🟢

@mickaelalibert mickaelalibert added cross-team Toutes les équipes de dev team-captains This is your captain speaking 👀 Tech Review Needed labels May 25, 2023
@pix-bot-github
Copy link

Une fois l'application déployée, elle sera accessible à cette adresse https://bot-pr252.review.pix.fr
Les variables d'environnement seront accessibles sur scalingo https://dashboard.scalingo.com/apps/osc-fr1/pix-bot-review-pr252/environment

@emeric-martineau emeric-martineau changed the title [TECH] Faire passer tous les logs par le logger [TECH] Faire passer tous les logs par le logger (PIX-8176) May 26, 2023
Copy link
Contributor

@octo-topi octo-topi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Chouette travail.
Il reste encore 21 occurences
Pour les trouver, ajouter une règle à .eslintrc.js

  rules: {
    'no-console': 'error',
  },

@octo-topi octo-topi changed the title [TECH] Faire passer tous les logs par le logger (PIX-8176) [TECH] Tracer avec le logger dédié partout (PIX-8176) May 30, 2023
@github-actions github-actions bot merged commit 55d8bba into main May 30, 2023
@github-actions github-actions bot deleted the rework-logs branch May 30, 2023 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants