Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Créer des RA en cas de réouverture de PR #238

Merged
merged 1 commit into from
Mar 31, 2023

Conversation

yoandl
Copy link
Contributor

@yoandl yoandl commented Mar 29, 2023

🦄 Problème

Les RA ne se recréent pas en cas de réouverture de PR

🤖 Proposition

Ajouter l'évènement

🌈 Remarques

Les tests sont modifiés pour éviter la duplication de code

@yoandl yoandl self-assigned this Mar 29, 2023
@pix-bot-github
Copy link

Une fois l'application déployée, elle sera accessible à cette adresse https://bot-pr238.review.pix.fr
Les variables d'environnement seront accessibles sur scalingo https://dashboard.scalingo.com/apps/osc-fr1/pix-bot-review-pr238/environment

@yoandl yoandl added team-captains This is your captain speaking 👀 Tech Review Needed labels Mar 29, 2023
Copy link
Contributor

@mickaelalibert mickaelalibert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quelques suggestions de formatage 🦄

test/acceptance/build/github_test.js Outdated Show resolved Hide resolved
test/acceptance/build/github_test.js Outdated Show resolved Hide resolved
test/acceptance/build/github_test.js Outdated Show resolved Hide resolved
@yoandl yoandl force-pushed the use-reopen-events-to-recreate-ra branch 2 times, most recently from bee76d6 to 27c1fcc Compare March 31, 2023 08:17
@yoandl yoandl force-pushed the use-reopen-events-to-recreate-ra branch from 27c1fcc to 1d18e5e Compare March 31, 2023 08:23
Copy link
Contributor

@mickaelalibert mickaelalibert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot merged commit 3278d49 into main Mar 31, 2023
@github-actions github-actions bot deleted the use-reopen-events-to-recreate-ra branch March 31, 2023 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants