Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TECH] ✨ Réessayer l'invalidation de cache en cas d'échec #231

Merged
merged 2 commits into from
Mar 7, 2023

Conversation

mickaelalibert
Copy link
Contributor

🦄 Problème

L'invalidation de cache Baleen peut renvoyer des 500, Baleen recommande de toujours tenter de relancer la requête plusieurs fois.

🤖 Proposition

Relancer la requête plusieurs fois (4 essais) pour faire passer l'invalidation de cache

💯 Pour tester

les tests sont vert
(On pourrait également rajouter les identifiants Baleen sur la RA et lancer une invalidation du cache sur une instance de test)

@mickaelalibert mickaelalibert added team-captains This is your captain speaking 👀 Tech Review Needed labels Mar 3, 2023
@mickaelalibert mickaelalibert self-assigned this Mar 3, 2023
@pix-bot-github
Copy link

Une fois l'application déployée, elle sera accessible à cette adresse https://bot-pr231.review.pix.fr
Les variables d'environnement seront accessibles sur scalingo https://dashboard.scalingo.com/apps/osc-fr1/pix-bot-review-pr231/environment

run/services/cdn.js Outdated Show resolved Hide resolved
Copy link
Contributor

@francois2metz francois2metz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❄️ ⛄ ⛷️ 🗻 🎄 LGTM 🎄 🗻 ⛷️ ⛄ ❄️

Test value are set closer to the test file
Logger is now used instead of console.log
@github-actions github-actions bot force-pushed the retry-cdn-invalidation branch from 3e7d18a to ddc179e Compare March 7, 2023 08:23
@github-actions github-actions bot merged commit ca14685 into main Mar 7, 2023
@github-actions github-actions bot deleted the retry-cdn-invalidation branch March 7, 2023 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants