Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expliciter la configuration de l'ecoMode #222

Merged
merged 2 commits into from
Mar 6, 2023

Conversation

octo-topi
Copy link
Contributor

@octo-topi octo-topi commented Feb 8, 2023

🎄 Problème

La configuration de l'ecoMode n'est pas claire.

On peut la confondre l'co-mode avec celle des autres tâches planifiées. :

  • usage sendInBlue;
  • pixSite.

De plus, elle n'est pas lue dans le config.js.

🎁 Proposition

Renommer les variables d'environnement.

STOP_CRON_TIME => REVIEW_APP_STOP_SCHEDULE 
RESTART_CRON_TIME => REVIEW_APP_START_SCHEDULE

🌟 Remarques

Penser à modifier les variables d'environnement sur les environnements aval (template RA, intégration, recette, production) avant de merger.

🎅 Pour tester

Alimenter les variables en RA

REVIEW_APP_START_SCHEDULE=0 0 8 * * 1-5
REVIEW_APP_STOP_SCHEDULE=0 0 19 * * 1-5

Redémarrer

Vérifier dans les logs le message

2022-12-30 14:41:51.080758679 +0100 CET [web-1] Started job stop-managed-review-apps with cron time "0 0 19 * * 1,2,3,4,5"
2022-12-30 14:41:51.085549357 +0100 CET [web-1] Started job restart-managed-review-apps with cron time "0 0 8 * * 1,2,3,4,5" 

@octo-topi octo-topi added cross-team Toutes les équipes de dev 👀 Tech Review Needed labels Feb 8, 2023
@octo-topi octo-topi self-assigned this Feb 8, 2023
@pix-bot-github
Copy link

Une fois l'application déployée, elle sera accessible à cette adresse https://bot-pr222.review.pix.fr
Les variables d'environnement seront accessibles sur scalingo https://dashboard.scalingo.com/apps/osc-fr1/pix-bot-review-pr222/environment

@octo-topi octo-topi force-pushed the tech-make-eco-mode-configuration-explicit branch from c014206 to fedd213 Compare February 23, 2023 08:18
Copy link
Contributor

@francois2metz francois2metz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❄️ ⛄ ⛷️ 🗻 🎄 LGTM 🎄 🗻 ⛷️ ⛄ ❄️

@github-actions github-actions bot merged commit 30c04f2 into main Mar 6, 2023
@github-actions github-actions bot deleted the tech-make-eco-mode-configuration-explicit branch March 6, 2023 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants