[CLEANUP] Sépare le callback d'interactivité de la partie build de la partie run #122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
francois2metz
added
Tech Review Needed
team-captains
francois2metz
force-pushed
the
split-interactive-views
branch
from
26ddff7 to
6ff14b7
Compare
VincentHardouin
approved these changes
May 17, 2022
Thomasevano
approved these changes
May 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦄 Problème
Les parties pix-box run et build sont censés être bien distincte. Le callback slack d’interactivité était partagé entre les 2 parties ce qui crée pas mal de confusion.
🤖 Solution
Séparer les deux routes entre build et run.
🌈 Remarques
La génération du manifest a été amélioré pour éviter de la duplication de routes.
💯 Pour tester
🟢