feat: contracts #4
Conversation
| @@ -0,0 +1,37 @@ | |||
| package gnoswap_optimizer | |||
|
|
|||
| func GetVault(tokenId uint64) Vault { | |||
There was a problem hiding this comment.
Most of getters in gnoswap is meant be call from off-chain (abci_query or adena or gnokey).
If GetVault() is same purpose, you should return primitive type.
There was a problem hiding this comment.
I thought this function would be more used other realms and the other getters more for rpc usage.
I just didn't split into two files as I don't have a lot of getters
contracts/vault.gno
Outdated
| } | ||
|
|
||
| liquidityRatio := computeLiquidityRatio(tokenId, parsedAmount) | ||
| _, liquidity, _, _, amount0, amount1, _ := position.DecreaseLiquidity(tokenId, liquidityRatio, uint256.NewUint(0).ToString(), uint256.NewUint(0).ToString(), time.Now().Unix()+1, false) |
There was a problem hiding this comment.
time.Now().Unix()+1, too short don't you think ??
There was a problem hiding this comment.
It isn't a order type AMM so the swap will be executed in the same transaction. So no need to add a higher deadline as it won't matter anyway
| func NewVault( | ||
| token0 string, | ||
| token1 string, | ||
| fee uint32, | ||
| tickLower int32, | ||
| tickUpper int32, | ||
| amount0 string, // *uint256.Uint | ||
| amount1 string, // *uint256.Uint | ||
| amount0Min string, // *uint256.Uint | ||
| amount1Min string, // *uint256.Uint | ||
| deadline int64, | ||
| ) { |
There was a problem hiding this comment.
It seems need to validate that token0 and token1 are valid and distinct token addresses
There was a problem hiding this comment.
The check is already being done in the Mint function of the position realm so will eb a double check
No description provided.