feat: getPersonas and callAsPersona #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanThomp507
force-pushed
the
DanThomp507/persona
branch
from
1e6229b to
8ac20e9
Compare
jtlacci
approved these changes
Dec 8, 2022
its-everdred
reviewed
Dec 8, 2022
There was a problem hiding this comment.
Mostly questions. I vaguely recall this work being discussed, but I don't have much context so it was a little hard to follow. The PR description is empty and the ticket just says "follow up work from" another ticket, which also has no description. 😅
I know we've talked about increasing ticket description detail, but @heyitschun do you mind adding a ticket to add a PR template to the SDK as well? That will at least prompt us to write in something.
its-everdred
approved these changes
Dec 12, 2022
|
🎉 This PR is included in version 3.4.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.