Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes ActiveSupport::XmlMini::IsolatedExecutionState #31

Closed
wants to merge 1 commit into from
Closed

Fixes ActiveSupport::XmlMini::IsolatedExecutionState #31

wants to merge 1 commit into from

Conversation

wilkosz
Copy link
Contributor

@wilkosz wilkosz commented Jan 9, 2022

Background

#30

Rails issue

rails/rails#43851

TODO

  • Optional require active_support/isolated_execution_state for active support versions beyond 6
  • Test

Closed Issues

@wilkosz wilkosz marked this pull request as ready for review January 9, 2022 04:55
@wilkosz
Copy link
Contributor Author

wilkosz commented Jan 9, 2022

@Jakenberg This is an ugly fix, but haven't worked with gems enough to understand implementation context. Some guidance would be greatly appreciated.

@0xjmp
Copy link
Owner

0xjmp commented Jan 9, 2022

I decided to just import all of activesupport so this won't be an issue as of 1.3.6, which is out now.

@0xjmp 0xjmp closed this Jan 9, 2022
@wilkosz wilkosz deleted the fix/#30 branch January 9, 2022 05:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

uninitialized constant ActiveSupport::XmlMini::IsolatedExecutionState
2 participants
@wilkosz @0xjmp