Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Azure - new stage 1 URL, new download link element #80

Merged
merged 1 commit into from
Jun 30, 2024

Conversation

psayler
Copy link
Contributor

@psayler psayler commented Jun 13, 2024

Summary by Sourcery

This pull request addresses issues with fetching IP ranges from Microsoft Azure by updating the URL and correcting the selector for the download link element.

  • Bug Fixes:
    • Updated the URL for fetching IP ranges from Microsoft Azure to the correct page.
    • Fixed the selector for the download link element to match the new structure of the Azure download page.

Copy link
Contributor

sourcery-ai bot commented Jun 13, 2024

Reviewer's Guide by Sourcery

This pull request updates the URL for fetching IP ranges from Microsoft Azure and changes the HTML element used to extract the direct download link. The changes ensure compatibility with the updated structure of the Azure download page.

File-Level Changes

Files Changes
sephiroth/providers/azure.py Updated the URL and HTML element selector to match the new structure of the Azure download page.

Tips
  • Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
  • You can change your review settings at any time by accessing your dashboard:
    • Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
    • Change the review language;
  • You can always contact us if you have any questions or feedback.

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @psayler - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

Copy link
Owner

@0xdade 0xdade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, thanks for submitting this fix! I'll merge it and see if I remember how to release a new version 😂

@0xdade 0xdade merged commit d511564 into 0xdade:main Jun 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants