Add cloudflare to targets #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
willk
commented
May 7, 2024
willk
commented
- Fixed Azure class. There was a problem with spacing
- Added cloudflare as a class using cloudflare's unauthenticated API call
- Updated README.md
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey @willk - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟡 Testing: 1 issue found
- 🟢 Complexity: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.
Comment on lines
+1
to
+10
| import requests | ||
| from sephiroth.providers.base_provider import BaseProvider | ||
|
|
||
|
|
||
| class Cloudflare(BaseProvider): | ||
| def __init__(self, excludeip6=False): | ||
| self.source_ranges = self._get_ranges() | ||
| self.processed_ranges = self._process_ranges(excludeip6) | ||
|
|
||
| def _get_ranges(self): |
There was a problem hiding this comment.
issue (testing): Missing tests for the new Cloudflare class.
The PR introduces a new Cloudflare class with methods _get_ranges and _process_ranges. It's crucial to add unit tests to verify that these methods behave as expected, especially since they involve external API calls and data processing.
0xdade
approved these changes
May 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.