Fix compile errors with rustc 1.74.0-nightly #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* apply updated rustfmt * fix compile errors & warnings * update dependencies * but pin serde to 1.0.152 to avoid breaking tests
|
hey, wow, I was just going back through the last 2 years of github notifications and i just saw this. I can't promise that I'll get around to merging your PR soon but I wanted to say thanks for checking out my project and sharing your work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! 🙂 I was trying to run your software, and ended up fixing a few errors preventing it from compiling on latest Nightly. I guess it's not ready to run yet, but hopefully this will fix your CI, or save you some time.
Updating serde breaks Bencode tests so I pinned serde to
1.0.152.May I suggest you choose a license for your project? In its current state it's de-facto proprietary. 🙃 Can't wait to see the spider crawling!
Commit message: